Skip to content

Revert Deployment Engine image tag pin in Helm chart#11906

Merged
brooke-hamilton merged 3 commits into
mainfrom
brooke-hamilton/revert-de-tag-pin
May 20, 2026
Merged

Revert Deployment Engine image tag pin in Helm chart#11906
brooke-hamilton merged 3 commits into
mainfrom
brooke-hamilton/revert-de-tag-pin

Conversation

@brooke-hamilton
Copy link
Copy Markdown
Member

@brooke-hamilton brooke-hamilton commented May 15, 2026

Description

Reverts the Deployment Engine (de) image tag pin in deploy/Chart/values.yaml. The tag was previously pinned to 0.56 for the v0.57.1 patch release. With that release out, the chart should fall back to using the Chart AppVersion as the default tag.

Type of change

  • This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

@brooke-hamilton
revert deployment image tag pinned in helm chart
982e1cd 
Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 15, 2026 02:42
@brooke-hamilton brooke-hamilton requested review from a team as code owners May 15, 2026 02:42
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copilot AI reviewed May 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reverts the Helm chart’s temporary pin of the Deployment Engine (de) image tag so the chart again defaults to using a tag derived from the chart AppVersion (via the chart helper logic), consistent with other control-plane components.

Changes:

  • Removed the hardcoded de.tag: 0.56 value from deploy/Chart/values.yaml.
  • Updated inline comments to reflect the defaulting behavior when de.tag is unset.

Comment thread deploy/Chart/values.yaml
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026 •
edited
Loading

Unit Tests

    2 files  ±0    423 suites  ±0   7m 22s ⏱️ +19s
5 145 tests ±0  5 143 ✅ ±0  2 💤 ±0  0 ❌ ±0 
6 183 runs  ±0  6 181 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 90586fa. ± Comparison against base commit 50c54ec.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.71%. Comparing base (50c54ec) to head (90586fa).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11906   +/-   ##
=======================================
  Coverage   51.71%   51.71%           
=======================================
  Files         725      725           
  Lines       45629    45629           
=======================================
+ Hits        23595    23599    +4     
+ Misses      19791    19789    -2     
+ Partials     2243     2241    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brooke-hamilton brooke-hamilton marked this pull request as draft May 18, 2026 17:18
@brooke-hamilton brooke-hamilton marked this pull request as ready for review May 20, 2026 20:21
@radius-functional-tests
Copy link
Copy Markdown

radius-functional-tests Bot commented May 20, 2026 •
edited
Loading

Radius functional test overview

🔍 Go to test action run

Click here to see the test run details
Name Value
Repository radius-project/radius
Commit ref 90586fa
Unique ID func7ba5e9dcf1
Image tag pr-func7ba5e9dcf1
  • gotestsum 1.13.0
  • KinD: v0.29.0
  • Dapr: 1.14.4
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func7ba5e9dcf1
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func7ba5e9dcf1
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func7ba5e9dcf1
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func7ba5e9dcf1
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func7ba5e9dcf1
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
✅ ucp-cloud functional tests succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@brooke-hamilton brooke-hamilton merged commit c2049c9 into main May 20, 2026
56 checks passed
@brooke-hamilton brooke-hamilton deleted the brooke-hamilton/revert-de-tag-pin branch May 20, 2026 21:03
@rad-ci-bot rad-ci-bot mentioned this pull request May 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@DariuszPorowski DariuszPorowski DariuszPorowski approved these changes

Assignees

No one assigned

Labels

pr:standard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brooke-hamilton @DariuszPorowski